RabbitMQ: Adding the queue_delivery_metrics OpenMetrics endpoint
#19963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
edgrz
changed the title
queue_delivery_metricsqueue_delivery_metrics OpenMetrics endpoint
|
Hello @edgrz, thank you for your contribution! It seems like they were added in this commit: rabbitmq/rabbitmq-server@bb93e71 Lastly, it would be great to include the new metrics in the tests as well! |
|
Hi @dkirov-dd, Thanks for the review. I'm using using rabbitMQ v4, which already exposes those. It was already part of v4.0.0, see. I updated manually the csv, but I'm facing an issue when setting up the dev environment locally following docs. By accident, when running the command So: I tried reinstalling, but even after a fresh install I'm getting the same error, so I'm guessing there's still a file somewhere that it's not being cleaned up when I do uninstall Could you help me please? I wanted te implement a test scenario to cover it, but I haven't been able yet. |
nevermind @dkirov-dd, I managed to fix it. I had to also remove an extra file I'll introduce rabbitMQ 4.0 version in the |
|
Nice! Let me know if you need any help from my side. |
|
Hi @dkirov-dd, I have introduced the v4.0 testing, as well as appended to existing I introduced a new test scenario that covers the new detailed endpoint with a I had to modify the Could you maybe help me or make the necessary fixes please? |
NouemanKHAL
reviewed
Apr 17, 2025
NouemanKHAL
reviewed
Apr 17, 2025
NouemanKHAL
previously approved these changes
Apr 17, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
NouemanKHAL
reviewed
Apr 17, 2025
temporal-github-worker-1
bot
dismissed
NouemanKHAL’s stale review
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- rabbitmq/changelog.d/19963.added
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
NouemanKHAL
approved these changes
Apr 17, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
dkirov-dd
approved these changes
Apr 17, 2025
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
…19963) * Integrating queue_delivery_metrics endpoint * csv * metadata * fixing csv * Tests * changelog * linting * skipif test * Format with `ddev test -fs rabbitmq` * Make tests pass * Implement review suggestions * Update changelog --------- Co-authored-by: David Kirov <[email protected]> Co-authored-by: NouemanKHAL <[email protected]> Co-authored-by: dkirov-dd <[email protected]> (cherry picked from commit 8ffbb76)
2 tasks
dkirov-dd
pushed a commit
that referenced
this pull request
Apr 22, 2025
…19963) (#20116) * Integrating queue_delivery_metrics endpoint * csv * metadata * fixing csv * Tests * changelog * linting * skipif test * Format with `ddev test -fs rabbitmq` * Make tests pass * Implement review suggestions * Update changelog --------- Co-authored-by: David Kirov <[email protected]> Co-authored-by: NouemanKHAL <[email protected]> Co-authored-by: dkirov-dd <[email protected]> (cherry picked from commit 8ffbb76) Co-authored-by: edgrz <[email protected]>
|
Hello @edgrz, this change will be included in the |
|
thanks @dkirov-dd for the review and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As part of
/detailedmetric endpoints, there's a queue delivery metrics one (docs), that were not integrated yet into datadog agent. This PR integrates them.Motivation
I prepared the DD agent to scrape such
/detailed?family=queue_delivery_metricsbut none of them were appearing in DD. So, looking into the source code I realize there was yet no mapping for there.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.